Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Chisel hierarchy API - Fixes #1356 #1361

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Fix Chisel hierarchy API - Fixes #1356 #1361

merged 1 commit into from
Feb 24, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Feb 23, 2023 •
edited
Loading

See #1356. S/o @tymcauley for the fix

Related PRs / Issues:
Fixes #1356

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez abejgonzalez self-assigned this Feb 23, 2023
@tymcauley
Copy link
Contributor

Thanks so much!

@tymcauley
Copy link
Contributor

Seems like spurious CI errors?

@jerryz123
Copy link
Contributor

I think its because the branch isn't up-to-date with main. I'll merge

@jerryz123 jerryz123 merged commit a7cb42d into main Feb 24, 2023
@jerryz123 jerryz123 deleted the fix-chisel-hier branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

Assignees

@abejgonzalez abejgonzalez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chisel Hierarchy API not working after Scala 2.13 update
3 participants
@abejgonzalez @tymcauley @jerryz123